Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS Loader Detection False Positives #34584

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Fix CSS Loader Detection False Positives #34584

merged 3 commits into from
Feb 23, 2022

Conversation

reubn
Copy link
Contributor

@reubn reubn commented Feb 19, 2022

test.css, test.scss etc. will falsely match on a loader that searches for the string test

fixes #34583

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

`test.css` will falsely match on a loader that searches for the string `test`
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 23, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary reubn/next.js patch-1 Change
buildDuration 15.2s 15.3s ⚠️ +72ms
buildDurationCached 6s 6s -3ms
nodeModulesSize 367 MB 367 MB ⚠️ +114 B
Page Load Tests Overall increase ✓
vercel/next.js canary reubn/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.796 2.815 ⚠️ +0.02
/ avg req/sec 894.07 888 ⚠️ -6.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.177 1.16 -0.02
/error-in-render avg req/sec 2123.9 2154.49 +30.59
Client Bundles (main, webpack)
vercel/next.js canary reubn/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary reubn/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary reubn/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary reubn/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary reubn/next.js patch-1 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary reubn/next.js patch-1 Change
buildDuration 18.3s 18.4s ⚠️ +115ms
buildDurationCached 6s 6s ⚠️ +38ms
nodeModulesSize 367 MB 367 MB ⚠️ +114 B
Page Load Tests Overall increase ✓
vercel/next.js canary reubn/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.772 2.785 ⚠️ +0.01
/ avg req/sec 901.99 897.64 ⚠️ -4.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.163 1.155 -0.01
/error-in-render avg req/sec 2150.52 2163.9 +13.38
Client Bundles (main, webpack)
vercel/next.js canary reubn/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary reubn/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary reubn/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary reubn/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary reubn/next.js patch-1 Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 4e874e5

@kodiakhq kodiakhq bot merged commit 70cd010 into vercel:canary Feb 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom CSS Configuration Detection False Positives
3 participants